Skip to content

For serializer class finding the more specific option should win, allow combination of namespace and custom #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krainboltgreene wants to merge 1 commit into
base: master
Choose a base branch
from
Open

For serializer class finding the more specific option should win, allow combination of namespace and custom #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/jsonapi-serializers/serializer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,18 +234,20 @@ def evaluate_attr_or_block(attribute_name, attr_or_block)
end

def self.find_serializer_class_name(object, options)
if options[:namespace]
return "#{options[:namespace]}::#{object.class.name}Serializer"
if object.respond_to?(:jsonapi_serializer_class_name) && options.key?(:namespace)
return "#{options[:namespace]}::#{object.jsonapi_serializer_class_name}"
end
if object.respond_to?(:jsonapi_serializer_class_name)
return object.jsonapi_serializer_class_name.to_s
end
if options[:namespace]
return "#{options[:namespace]}::#{object.class.name}Serializer"
end
"#{object.class.name}Serializer"
end

def self.find_serializer_class(object, options)
class_name = find_serializer_class_name(object, options)
class_name.constantize
find_serializer_class_name(object, options).constantize
end

def self.find_serializer(object, options)
Expand Down