Fix login bug #117
Open
Fix login bug #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Yeah I dismissed it as not a problem because looking into it I think it's fine. |
m4v15
requested changes
May 28, 2018
Collaborator
m4v15
left a comment
m4v15
left a comment
There was a problem hiding this comment.
Not really changes just a question to double check things
| if (access) { | ||
| verifyToken(req.cookies) | ||
| .then(() => next()) | ||
| .catch(err => |
Collaborator
There was a problem hiding this comment.
Wasn't it like this originally? Why did it get changed - if there was a reason, will changing it back maybe break something else?
Collaborator
There was a problem hiding this comment.
as in, we had it doing a redirect which then got changed into a res.send at some point
Collaborator
Author
There was a problem hiding this comment.
i'm not actually sure why it got changed i don't really remember, but i do know that we were doing res.send just cause we had the form's validation or Axios which is doing the request to the server and not the the browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weird last time i checked the repo the security problem was there now nothing... 😅
rel #115