[#580] Add prepareAbilities actor hook#581
Closed
roth-michael wants to merge 1 commit intofoundryvtt:masterfrom
Closed
[#580] Add prepareAbilities actor hook#581roth-michael wants to merge 1 commit intofoundryvtt:masterfrom
prepareAbilities actor hook#581roth-michael wants to merge 1 commit intofoundryvtt:masterfrom
Conversation
aaclayton
requested changes
Jan 15, 2026
| /* -------------------------------------------- */ | ||
|
|
||
| /** @inheritDoc */ | ||
| _prepareAbilities() { |
Contributor
There was a problem hiding this comment.
This looks good, but I'm worried about order of operations and whether we can wait to compute total ability scores until prepareDerivedData. I suspect that there are some things that happen during prepareEmbeddedDocuments that currently reference and depend on the values of ability scores.
I have not looked closely, just a hunch. Do you foresee any issues with computing a final ability score after embedded items are prepared?
Contributor
Author
There was a problem hiding this comment.
Ah, yeah, you're right. Specifically preparing defenses (physical and save) and preparing skills. Not sure what the best way to work around this is. Can discuss later with the other PR concerns.
Contributor
Author
|
Closed in lieu of #669 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #580
Nothing changes for Adversary actors, since we never consider any
bonusfor abilities to them. Can change that, if desired. For Hero actors:prepareBaseDatanow calls_prepareBaseAbilities, which is the same as it was before but doesn't clampability.valueand doesn't includeability.bonusprepareDerivedDatanow calls theprepareAbilitiesactor hook, then_prepareAbilities, which addsability.bonusto eachability.valueand clamps it between 0 and 12.This means one can now provide bonuses to ability scores for Hero actors by either:
system.abilities.[ability].bonus( or.value, as before) via AEabilities.[ability].bonusor.valuein theprepareAbilitieshook.