[#6335] Add ModifyItem advancement for enchanting existing items#6705
Open
[#6335] Add ModifyItem advancement for enchanting existing items#6705
ModifyItem advancement for enchanting existing items#6705Conversation
|
What if a matching item is added later? |
Collaborator
Author
Yep |
Contributor
|
Any plans for this to be retroactive in the future like mentioned in the original issue? |
Adds a new advancement type that allows for applying an enchantment to an existing item on an actor's sheet. This advancement contains a list of enchantments to apply, and a list of identifiers that are used to find the items to apply those enchantments to. During the advancement process, each enchantment will be displayed with a list of matching items below it. ### Future Improvement - Allow user control over what items are actually enchanted - Support rider activities & effects once #6357 is resolved Closes #6335
arbron
force-pushed
the
advancement/enchant
branch
from
ac7d384 to
9f5a1a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new advancement type that allows for applying an enchantment to an existing item on an actor's sheet. This advancement contains a list of enchantments to apply, and a list of identifiers that are used to find the items to apply those enchantments to.
When configured directly on a class, species, or background, the configuration dialog doesn't include the selection dropdown nor the "Disassociate" button because there is not "Effects" tab visible on those item types.
During the advancement process, each enchantment will be displayed with a list of matching items below it.
Future Improvement
Closes #6335