Fix hidden check outcome vanishing when player rerolls#19353
Open
DocSchlock wants to merge 2 commits intofoundryvtt:v13-devfrom
Open
Fix hidden check outcome vanishing when player rerolls#19353DocSchlock wants to merge 2 commits intofoundryvtt:v13-devfrom
DocSchlock wants to merge 2 commits intofoundryvtt:v13-devfrom
Conversation
Collaborator
|
I plan to look at this in more detail at a future date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17420
Issue: When a player re-rolls a check with Show Check Outcomes disabled, the check outcome GM box vanishes from the re-roll.
Cause: when the re-roll is generated from the player's end, the gm-visible box isn't present in the HTML for the original roll. Since the elements aren't present, the outcome update code fails to run, removing the box completely.
Resolution: test if the check outcome box is in the old flavor. If it is, use the original workflow to replace the check outcomes. If not, insert a new check outcome element from the reroll after the action section.