Add support for adding skill choices to Treat Wounds#20051
Open
websterguy wants to merge 2 commits intofoundryvtt:v13-devfrom
Open
Add support for adding skill choices to Treat Wounds#20051websterguy wants to merge 2 commits intofoundryvtt:v13-devfrom
websterguy wants to merge 2 commits intofoundryvtt:v13-devfrom
Conversation
Creates an array in flags to hold alternate skills to use for treat wounds and changes the treat wounds macro to add skills from there to its menu. This will generalize for any possible future features and homebrew additions. May need explicit support for Chirurgeon and Natural Medicine added back to the macro unless existing features could be migrated to add the rule element to them.
stwlam
requested changes
Aug 28, 2025
Comment on lines
+50
to
+55
| const skillSelectOptions = [...skills] | ||
| .map( | ||
| (skill) => | ||
| `<option value="${skill}">${game.i18n.localize("PF2E.Skill." + game.pf2e.system.sluggify(skill, { camel: "bactrian" }))}</option>`, | ||
| ) | ||
| .join(); |
Collaborator
There was a problem hiding this comment.
At this point we should probably be using a template.
Contributor
Author
Yeah, I mentioned that it would need a migration unless I put back the explicit Natural Medicine and Chirurgeon checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates an array in flags to hold alternate skills to use for treat wounds and changes the treat wounds macro to add skills from there to its menu. This will generalize for any possible future features and homebrew additions.
May need explicit support for Chirurgeon and Natural Medicine added back to the macro unless existing features could be migrated to add the rule element to them.