Replace CompendiumBrowser checkbox filters with a tri-state filter component#20282
Open
In3luki wants to merge 1 commit intofoundryvtt:v13-devfrom
Open
Replace CompendiumBrowser checkbox filters with a tri-state filter component#20282In3luki wants to merge 1 commit intofoundryvtt:v13-devfrom
CompendiumBrowser checkbox filters with a tri-state filter component#20282In3luki wants to merge 1 commit intofoundryvtt:v13-devfrom
Conversation
Collaborator
|
Any way to get a minimal fix extracted from this? |
7223560 to
b4191e7
Compare
b4191e7 to
fbb8cb9
Compare
fbb8cb9 to
abf5b86
Compare
abf5b86 to
7ba5b83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one has grown a bit bigger than I anticipated so I'm pushing this up for review before adding any more to it. The browser should overall work the same as before but there might be some filter edge cases that are not covered.
Predicatewhich should make it even easier to implement new filter options.Defensefilter to the spell tab that allows filtering by save, AC, basic save, etc.FilterContainerwrapper to the indiviudal filters to remove the need for thegetClearFunctionfunction.