Skip to content

Comments

Automates physical resistance for Inspire Heroics (Defense) effects#20725

Open
Theroxenes wants to merge 4 commits intofoundryvtt:v13-devfrom
Theroxenes:v13-dev
Open

Automates physical resistance for Inspire Heroics (Defense) effects#20725
Theroxenes wants to merge 4 commits intofoundryvtt:v13-devfrom
Theroxenes:v13-dev

Conversation

@Theroxenes
Copy link

Adds resistance rules elements to Inspire Heroics (Defense) spell effects.
Renames effects and labels to match remastered name Rallying Anthem.
Updates descriptions to reflect added rules element.

@ammalagonc
Copy link
Collaborator

Rallying Anthem has a dedicated effect.

I believe we are keeping this effect as is for Legacy purposes (aka folks still using the Legacy version of the class. A data lead can potentially confirm or refute this.

@Theroxenes
Copy link
Author

Theroxenes commented Nov 14, 2025

Rallying Anthem has a dedicated effect.

I believe we are keeping this effect as is for Legacy purposes (aka folks still using the Legacy version of the class. A data lead can potentially confirm or refute this.

Thank you for the info, the motivation for creating this PR was that the Workbench macro for Fortissimo uses this spell effect but in that case it would probably be better to add a new effect there. The legacy Inspire Defense does provide resistance as well though.

@ammalagonc ammalagonc added the pr: data update Updates to existing actors and items label Nov 14, 2025
@pedrogrullada
Copy link
Collaborator

There's conflicts because of the recent compendium split. You need to rebase.

Theroxenes and others added 4 commits December 14, 2025 08:25
Adds resistance rules elements to Inspire Heroics (Defense) spell
effects.
Also renames them to match remastered Rallying Anthem, and updated
description to reflect added rules element.
Co-authored-by: Ambrose <45524683+ammalagonc@users.noreply.github.com>
Adds resistance rules elements to Inspire Heroics (Defense) spell
effects.
Also renames them to match remastered Rallying Anthem, and updated
description to reflect added rules element.
Co-authored-by: Ambrose <45524683+ammalagonc@users.noreply.github.com>
@Theroxenes
Copy link
Author

Rebase done, thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: data update Updates to existing actors and items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants