Add a parameter to hide /act skill label#21525
Open
Cuingamehtar wants to merge 1 commit intofoundryvtt:v13-devfrom
Open
Add a parameter to hide /act skill label#21525Cuingamehtar wants to merge 1 commit intofoundryvtt:v13-devfrom
Cuingamehtar wants to merge 1 commit intofoundryvtt:v13-devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to use those in descriptions and hazard disables when the button label is the same as the used skill (to avoid
Athletics (Athletics)).I wanted to have an option to display the default statistic too, but the current type of actions collection doesn't allow getting the default statistic of the action, so I skipped it for now. The parameter name was chosen similar to "show-dc", but as I don't think there is a need to hide it from non-GM, the choice would be simpler.
I'm not sure what would be the better name for the parameter value. Currently it's "false" or "never" to not show the skill label (potentially expanding to "true" or "always" in case there is ever a need to show the default skill label). Those are just my suggestions.