🛡️ Sentinel: Add input validation for agent metadata extraction #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛡️ Sentinel: [security improvement]
Description
Added input validation for agent metadata extraction to prevent potential log injection or data pollution.
Vulnerability
Previously,
agent_instance_id,parent_session_id, andparent_task_idwere extracted from user prompts without validation. This could allow malicious actors to inject arbitrary strings (including path traversal characters or HTML/script tags) into the plugin's logs or metadata fields.Impact
Medium/Low. While mostly leading to log pollution or potentially Stored XSS in log viewers (if vulnerable), it corrupted the integrity of the session metadata.
Fix
Implemented a strict
isValidIdcheck that only allows alphanumeric characters, hyphens, and underscores for extracted IDs. Malformed IDs are now ignored.Verification
<script>or../are rejected using a test script.bun test).PR created automatically by Jules for task 16303121858403540985 started by @fpr1m3