Skip to content

Fix field validator behavior in converter field #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
AlexShukel wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix field validator behavior in converter field #306

AlexShukel wants to merge 2 commits into from

Conversation

@AlexShukel
Copy link
Collaborator

@AlexShukel AlexShukel commented Sep 12, 2023

No description provided.

@AlexShukel AlexShukel added the breaking changes Changes causing the next version to be incompatible with the previous ones label Sep 12, 2023
@AlexShukel AlexShukel self-assigned this Sep 12, 2023
@AlexShukel AlexShukel marked this pull request as draft September 12, 2023 12:09
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

Coverage report for /home/runner/work/reactive-forms/reactive-forms/packages/core

Multiple errors occurred

 1 | Error: The process '/home/runner/setup-pnpm/node_modules/.bin/pnpm' failed with exit code 1
 2 | Coverage output file not found. (file "/home/runner/work/reactive-forms/reactive-forms/packages/core/report.json" not found)
 3 | Getting code coverage data failed.
St.❔
 Category Percentage Covered / Total
🟢 Statements 95.5% 701/734
🟢 Branches 80.31% 155/193
🟢 Functions 93.29% 153/164
🟢 Lines 95.24% 620/651

Test suite run success

149 tests passing in 31 suites.

Report generated by 🧪jest coverage report action from bf2bf5b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@AlexShukel AlexShukel

Labels

breaking changes Changes causing the next version to be incompatible with the previous ones

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AlexShukel