-
Notifications
You must be signed in to change notification settings - Fork 16
first commit #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
QMDAKA
wants to merge
1
commit into
framgia:master
Choose a base branch
from
QMDAKA:develop-springmvc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
first commit #7
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <module org.jetbrains.idea.maven.project.MavenProjectsManager.isMavenModule="true" type="JAVA_MODULE" version="4"> | ||
| <component name="NewModuleRootManager" LANGUAGE_LEVEL="JDK_1_7" inherit-compiler-output="false"> | ||
| <output url="file://$MODULE_DIR$/target/classes" /> | ||
| <output-test url="file://$MODULE_DIR$/target/test-classes" /> | ||
| <content url="file://$MODULE_DIR$"> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/main/java" isTestSource="false" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/main/resources" type="java-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/test/java" isTestSource="true" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/target" /> | ||
| </content> | ||
| <orderEntry type="inheritedJdk" /> | ||
| <orderEntry type="sourceFolder" forTests="false" /> | ||
| <orderEntry type="library" name="Maven: com.google.guava:guava:18.0" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.boot:spring-boot-starter-data-jpa:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.boot:spring-boot-starter:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.boot:spring-boot:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.boot:spring-boot-autoconfigure:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.boot:spring-boot-starter-logging:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: ch.qos.logback:logback-classic:1.1.8" level="project" /> | ||
| <orderEntry type="library" name="Maven: ch.qos.logback:logback-core:1.1.8" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.slf4j:jul-to-slf4j:1.7.22" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.slf4j:log4j-over-slf4j:1.7.22" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.boot:spring-boot-starter-aop:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.aspectj:aspectjweaver:1.8.9" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.boot:spring-boot-starter-jdbc:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.tomcat:tomcat-jdbc:8.5.6" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.tomcat:tomcat-juli:8.5.6" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework:spring-jdbc:4.3.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.hibernate:hibernate-core:5.0.11.Final" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.jboss.logging:jboss-logging:3.3.0.Final" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.hibernate.javax.persistence:hibernate-jpa-2.1-api:1.0.0.Final" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.javassist:javassist:3.20.0-GA" level="project" /> | ||
| <orderEntry type="library" name="Maven: antlr:antlr:2.7.7" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.jboss:jandex:2.0.0.Final" level="project" /> | ||
| <orderEntry type="library" name="Maven: dom4j:dom4j:1.6.1" level="project" /> | ||
| <orderEntry type="library" name="Maven: xml-apis:xml-apis:1.4.01" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.hibernate.common:hibernate-commons-annotations:5.0.1.Final" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.hibernate:hibernate-entitymanager:5.0.11.Final" level="project" /> | ||
| <orderEntry type="library" name="Maven: javax.transaction:javax.transaction-api:1.2" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.data:spring-data-jpa:1.10.6.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.data:spring-data-commons:1.12.6.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework:spring-orm:4.3.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework:spring-context:4.3.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework:spring-tx:4.3.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework:spring-beans:4.3.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.slf4j:jcl-over-slf4j:1.7.22" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework:spring-aspects:4.3.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.boot:spring-boot-starter-thymeleaf:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.thymeleaf:thymeleaf-spring4:2.1.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.thymeleaf:thymeleaf:2.1.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: ognl:ognl:3.0.8" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.unbescape:unbescape:1.1.0.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: nz.net.ultraq.thymeleaf:thymeleaf-layout-dialect:1.4.0" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.codehaus.groovy:groovy:2.4.7" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.boot:spring-boot-starter-web:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.boot:spring-boot-starter-tomcat:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.tomcat.embed:tomcat-embed-core:8.5.6" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.tomcat.embed:tomcat-embed-el:8.5.6" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.tomcat.embed:tomcat-embed-websocket:8.5.6" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.hibernate:hibernate-validator:5.2.4.Final" level="project" /> | ||
| <orderEntry type="library" name="Maven: javax.validation:validation-api:1.1.0.Final" level="project" /> | ||
| <orderEntry type="library" name="Maven: com.fasterxml:classmate:1.3.3" level="project" /> | ||
| <orderEntry type="library" name="Maven: com.fasterxml.jackson.core:jackson-databind:2.8.5" level="project" /> | ||
| <orderEntry type="library" name="Maven: com.fasterxml.jackson.core:jackson-annotations:2.8.5" level="project" /> | ||
| <orderEntry type="library" name="Maven: com.fasterxml.jackson.core:jackson-core:2.8.5" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework:spring-web:4.3.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework:spring-webmvc:4.3.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework:spring-expression:4.3.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" scope="RUNTIME" name="Maven: mysql:mysql-connector-java:5.1.40" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: org.springframework.boot:spring-boot-starter-test:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: org.springframework.boot:spring-boot-test:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: org.springframework.boot:spring-boot-test-autoconfigure:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: com.jayway.jsonpath:json-path:2.2.0" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: net.minidev:json-smart:2.2.1" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: net.minidev:accessors-smart:1.1" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: junit:junit:4.12" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: org.assertj:assertj-core:2.5.0" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: org.mockito:mockito-core:1.10.19" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: org.objenesis:objenesis:2.1" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: org.hamcrest:hamcrest-core:1.3" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: org.hamcrest:hamcrest-library:1.3" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: org.skyscreamer:jsonassert:1.3.0" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: org.json:json:20140107" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework:spring-core:4.3.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" scope="TEST" name="Maven: org.springframework:spring-test:4.3.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.webjars:bootstrap:3.3.7" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.elasticsearch:elasticsearch:1.6.0" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.lucene:lucene-core:4.10.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.lucene:lucene-analyzers-common:4.10.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.lucene:lucene-queries:4.10.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.lucene:lucene-memory:4.10.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.lucene:lucene-highlighter:4.10.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.lucene:lucene-queryparser:4.10.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.lucene:lucene-sandbox:4.10.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.lucene:lucene-suggest:4.10.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.lucene:lucene-misc:4.10.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.lucene:lucene-join:4.10.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.lucene:lucene-grouping:4.10.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.apache.lucene:lucene-spatial:4.10.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: com.spatial4j:spatial4j:0.4.1" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.antlr:antlr-runtime:3.5" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.ow2.asm:asm:4.1" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.ow2.asm:asm-commons:4.1" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.yaml:snakeyaml:1.17" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.webjars:jquery:2.1.4" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.boot:spring-boot-starter-security:1.4.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework:spring-aop:4.3.5.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.security:spring-security-config:4.1.4.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.security:spring-security-core:4.1.4.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.springframework.security:spring-security-web:4.1.4.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.thymeleaf.extras:thymeleaf-extras-springsecurity4:2.1.3.RELEASE" level="project" /> | ||
| <orderEntry type="library" name="Maven: org.slf4j:slf4j-api:1.7.22" level="project" /> | ||
| </component> | ||
| </module> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>demo-thym</groupId> | ||
| <artifactId>demo-thym</artifactId> | ||
| <version>1.0-SNAPSHOT</version> | ||
| <packaging>jar</packaging> | ||
|
|
||
| <name>SpringThymeleaf</name> | ||
| <description>Demo project for Spring Boot</description> | ||
| <parent> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>1.4.3.RELEASE</version> | ||
| <relativePath/> <!-- lookup parent from mvs.repository --> | ||
| </parent> | ||
|
|
||
|
|
||
| <dependencies> | ||
| <!-- https://mvnrepository.com/artifact/com.google.guava/guava --> | ||
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>18.0</version> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-data-jpa</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-thymeleaf</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-web</artifactId> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>mysql</groupId> | ||
| <artifactId>mysql-connector-java</artifactId> | ||
| <scope>runtime</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-test</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.webjars</groupId> | ||
| <artifactId>bootstrap</artifactId> | ||
| <version>3.3.7</version> | ||
| </dependency> | ||
|
|
||
|
|
||
| <!-- https://mvnrepository.com/artifact/org.elasticsearch/elasticsearch --> | ||
| <dependency> | ||
| <groupId>org.elasticsearch</groupId> | ||
| <artifactId>elasticsearch</artifactId> | ||
| <version>1.6.0</version> | ||
| </dependency> | ||
|
|
||
| <!-- https://mvnrepository.com/artifact/org.webjars/jquery --> | ||
| <dependency> | ||
| <groupId>org.webjars</groupId> | ||
| <artifactId>jquery</artifactId> | ||
| <version>2.1.4</version> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-security</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.thymeleaf.extras</groupId> | ||
| <artifactId>thymeleaf-extras-springsecurity4</artifactId> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.webjars</groupId> | ||
| <artifactId>bootstrap</artifactId> | ||
| <version>3.3.7</version> | ||
| </dependency> | ||
|
|
||
| <!-- https://mvnrepository.com/artifact/org.webjars/jquery --> | ||
| <dependency> | ||
| <groupId>org.webjars</groupId> | ||
| <artifactId>jquery</artifactId> | ||
| <version>2.1.4</version> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-maven-plugin</artifactId> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <source>1.7</source> | ||
| <target>1.7</target> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
|
|
||
| </project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| package mvs; | ||
|
|
||
| import org.springframework.boot.autoconfigure.EnableAutoConfiguration; | ||
| import org.springframework.boot.autoconfigure.SpringBootApplication; | ||
| import org.springframework.boot.builder.SpringApplicationBuilder; | ||
| import org.springframework.boot.web.support.SpringBootServletInitializer; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.ComponentScan; | ||
| import org.springframework.context.annotation.Configuration; | ||
| import org.springframework.data.jpa.repository.config.EnableJpaRepositories; | ||
| import org.springframework.orm.jpa.JpaVendorAdapter; | ||
| import org.springframework.orm.jpa.vendor.Database; | ||
| import org.springframework.orm.jpa.vendor.HibernateJpaVendorAdapter; | ||
| import org.springframework.transaction.annotation.EnableTransactionManagement; | ||
|
|
||
| /** | ||
| * Created by quangminh on 27/06/2017. | ||
| */ | ||
| @Configuration | ||
| @ComponentScan(basePackageClasses = SpringApplication.class) | ||
| @EnableJpaRepositories(basePackages = "mvs.repository") | ||
| @EnableTransactionManagement | ||
| @EnableAutoConfiguration | ||
| @SpringBootApplication | ||
| public class SpringApplication extends SpringBootServletInitializer { | ||
|
|
||
| @Bean | ||
| public JpaVendorAdapter jpaVendorAdapter() { | ||
| HibernateJpaVendorAdapter jpaVendorAdapter = new HibernateJpaVendorAdapter(); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Không dùng HibernateJpaVendorAdapter em ơi. |
||
| jpaVendorAdapter.setDatabase(Database.MYSQL); | ||
| jpaVendorAdapter.setShowSql(true); | ||
| jpaVendorAdapter.setGenerateDdl(true); | ||
| return jpaVendorAdapter; | ||
| } | ||
| @Override | ||
| protected SpringApplicationBuilder configure(SpringApplicationBuilder application) { | ||
| return application.sources(SpringApplication.class); | ||
| } | ||
|
|
||
| public static void main(String[] args) { | ||
| org.springframework.boot.SpringApplication.run(SpringApplication.class, args); | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package mvs.config; | ||
|
|
||
| import org.elasticsearch.client.Client; | ||
|
|
||
| /** | ||
| * Created by quangminh on 07/07/2017. | ||
| */ | ||
| public class AppConfig { | ||
| static String imageSrc; | ||
| static Client client; | ||
|
|
||
| public static Client getClient() { | ||
| return client; | ||
| } | ||
|
|
||
| public static void setClient(Client client) { | ||
| AppConfig.client = client; | ||
| } | ||
|
|
||
| public static String getImageSrc() { | ||
| return imageSrc; | ||
| } | ||
|
|
||
| public static void setImageSrc(String imageSrc) { | ||
| AppConfig.imageSrc = imageSrc; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package mvs.config; | ||
|
|
||
|
|
||
| import org.springframework.security.core.GrantedAuthority; | ||
| import org.springframework.security.core.userdetails.User; | ||
|
|
||
| import java.util.Collection; | ||
|
|
||
| /** | ||
| * Created by quangminh on 25/07/2017. | ||
| */ | ||
| public class CustomUserDetails extends User { | ||
| public CustomUserDetails(String username, String password, Collection<? extends GrantedAuthority> authorities) { | ||
| super(username, password, authorities); | ||
| } | ||
| private String firstName; | ||
| private String lastName; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trùng lib rồi em ơi
Line 54 có khai báo rồi kìa