Bug fixes found when running experiments #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ravinkohli
commented
Apr 1, 2021
ravinkohli
commented
- Moved to warn user not error for unexpected update
franchuterivera
requested changes
Apr 1, 2021
| "This update {} will be removed".format(node.__class__.__name__, | ||
| components.keys(), choice, update), | ||
| UserWarning) | ||
| self.search_space_updates.updates.remove(update) |
Owner
There was a problem hiding this comment.
Can you call the remove outside of the foreach loop? Like I don't think it is a good idea to update the list while iterating on it
Collaborator
Author
There was a problem hiding this comment.
okay, I'll do so
| "This update {} will be removed".format(node.__class__.__name__, | ||
| components.keys(), split_hyperparameter[0], | ||
| update), UserWarning) | ||
| self.search_space_updates.updates.remove(update) |
| if split_hyperparameter[1] not in component. \ | ||
| get_hyperparameter_search_space(dataset_properties=self.dataset_properties): | ||
| if split_hyperparameter[1] not in \ | ||
| component.get_hyperparameter_search_space(dataset_properties=self.dataset_properties): |
Owner
There was a problem hiding this comment.
can you put the new line after the parenthesis?
| component.get_hyperparameter_search_space( | ||
| dataset_properties=self.dataset_properties).get_hyperparameter_names(), | ||
| split_hyperparameter[1], update), UserWarning) | ||
| self.search_space_updates.updates.remove(update) |
| if update.hyperparameter not in node.get_hyperparameter_search_space( | ||
| dataset_properties=self.dataset_properties): | ||
| if update.hyperparameter not in \ | ||
| node.get_hyperparameter_search_space(dataset_properties=self.dataset_properties): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.