Skip to content

fix(user_profile): validate fields received by the API #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sokumon merged 2 commits into from
Sep 3, 2025
Merged

fix(user_profile): validate fields received by the API #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
094d78d
fix(user_profile): validate fields received by the API
akhilnarang Sep 1, 2025
169403b
fix(semgrep): translate string
akhilnarang Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eps/eps/doctype/energy_point_log/energy_point_log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,4 +394,4 @@ def get_footer_message(timespan):


def delete_energy_point_logs_for_user(user, event):
frappe.db.delete("Energy Point Log", {"user": user.name})
frappe.db.delete("Energy Point Log", {"user": user.name})
11 changes: 7 additions & 4 deletions eps/eps/page/user_profile/user_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@


@frappe.whitelist()
def get_energy_points_heatmap_data(user, date):
def get_energy_points_heatmap_data(user: str, date: str | None):
try:
date = getdate(date)
except Exception:
Expand All @@ -29,7 +29,10 @@ def get_energy_points_heatmap_data(user, date):


@frappe.whitelist()
def get_energy_points_percentage_chart_data(user, field):
def get_energy_points_percentage_chart_data(user: str, field: str):
if field not in ("type", "reference_doctype", "rule"):
frappe.throw(frappe._("Invalid field for grouping"))

result = frappe.get_all(
"Energy Point Log",
filters={"user": user, "type": ["!=", "Review"]},
Expand All @@ -46,7 +49,7 @@ def get_energy_points_percentage_chart_data(user, field):


@frappe.whitelist()
def get_user_rank(user):
def get_user_rank(user: str):
month_start = datetime.today().replace(day=1)
monthly_rank = frappe.get_all(
"Energy Point Log",
Expand Down Expand Up @@ -88,7 +91,7 @@ def update_profile_info(profile_info):


@frappe.whitelist()
def get_energy_points_list(start, limit, user):
def get_energy_points_list(start: int, limit: int, user: str):
return frappe.db.get_list(
"Energy Point Log",
filters={"user": user, "type": ["!=", "Review"]},
Expand Down