Update README.md for version 0.8 #13
Conversation
Co-authored-by: fredli74 <6632456+fredli74@users.noreply.github.com>
README.md
Outdated
|
|
||
| **Environment variables** | ||
|
|
||
| * `UMASK` - Set file creation permissions mask in octal format (default: `077` for owner-only access). Example: `UMASK=027` for group-readable files. |
There was a problem hiding this comment.
UMASK is server only, added for detailed access control over .dat, .meta, .idx, .db, .trn
There was a problem hiding this comment.
Clarified in a2909d4. Added note that UMASK controls access permissions for server data files (.dat, .meta, .idx, .db, .trn).
README.md
Outdated
| * `-full` - Force a full (non-incremental) backup | ||
| * `-verbose` - Enable verbose output | ||
| * `-progress` - Show progress information | ||
| * `-paint` - Use colored/formatted output |
There was a problem hiding this comment.
-paint draws symbols for each block operation, it is not color.
There was a problem hiding this comment.
Fixed in a2909d4. Updated description to: "Draw symbols for each block operation (* = uploaded, - = skipped, space = unchanged)"
Co-authored-by: fredli74 <6632456+fredli74@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2909d479e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * Each block hash (block ID) is calculated and sent to the server. | ||
| * Server requests only blocks that it does not already have. In combination with the rollsum splitting this allows the server to only request parts of files that were not previously stored. | ||
| * File metadata such as file name, size, modification time and attributes are stored in a directory block. | ||
| * Symbolic links are preserved during backup and restore. |
There was a problem hiding this comment.
The README says symlinks are preserved during backup and restore, but storePath explicitly uses os.Stat for top-level paths (so it follows symlinks) and only uses os.Lstat for non-top-level entries; this means a symlink passed directly on the command line is stored as the target file instead of a link. This is observable when backing up a single symlink path, so the blanket statement is inaccurate unless you note the top-level exception (see hashback/store.go around storePath, os.Stat vs os.Lstat, and the symlink handling branch).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@copilot Rephrase this to say that symbolic links under backup folders or something similar, to exclude the top-level path selection.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.