Verify vehicle.maximumLevel is always non-null as designed #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Fix syncing schedule level display with local edits
Verify vehicle.maximumLevel is always non-null as designed
Jan 31, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed review feedback requesting verification that
vehicle.maximumLevelis always a number and never null, confirming the design decision to hide level UI whenschedule.level === null.Verification Results
vehicle.maximumLevelis guaranteed non-null:maximumLevel: Int!(non-nullable)maximum_charge smallint NOT NULLmaximumLevel: numberschedule.levelis intentionally nullable:level: Int(nullable)level smallint(nullable)The
v-if="localSchedule.level !== null"condition in commit f6057c5 correctly hides level UI only for schedules without level support.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.