Clarify levelSlider initialization design - single source of truth #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed review feedback on PR #946 regarding
levelSliderinitialization strategy. The concern was about removingvehicle.maximumLevelas a fallback, potentially defaulting to 0% instead of a sensible charging level.Design Clarification
The current implementation follows a single-source-of-truth pattern:
level: this.vehicle.maximumLevelinvehicle-schedule.vue:87this.schedule.level || 0as type safety only|| 0fallback: Only triggers for future schedule types with null levels (e.g., "manual stop" events)This eliminates the previous double-default pattern where both schedule creation AND levelSlider initialization would set
maximumLevel. For any new schedule,levelSliderreceives the correct value through the schedule object itself.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.