Merged
Conversation
Signed-off-by: Guillaume Belanger <guillaume.belanger27@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Hi and thank you for maintaining the NAS library. We use it in Ella Core, and we log differently from this library. Because of this reason we want to disable logging in the nas library. To do so, we could set the log level to "panic", but the lib still logs a
set log levelmessage right as we do so. Here we change the order of setting the log level and loggingset log levelin order for this log to never show up in our deployments.Longer term: replace logging with returning errors
Most libraries return errors and leave logging decisions to the caller. This allows the lib to be used by different projects with varying approaches to logging. I think this approach would be preferable here, but it would be a larger effort and a breaking change.
If you are interested in taking that route, I have a branch of
nasthat does exactly that: