Generate data.json instead of data.js for TypeScript compatibility#49
Open
phanect wants to merge 4 commits intofreeall:masterfrom
Open
Generate data.json instead of data.js for TypeScript compatibility#49phanect wants to merge 4 commits intofreeall:masterfrom
phanect wants to merge 4 commits intofreeall:masterfrom
Conversation
npm package file generated by `npm pack`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, currency-code/data is not typed and does not work with TypeScript code.
Example code and `tsc` output
test.ts
Output by
tsc --noEmitThis PR generates data.json instead of data.js so that you can import the data in the JSON format.
With this change, you can import the data from TypeScript code as follows:
data.js is still generated for compatibility. You don't have to bump the major version this time.
I considered converting the entire codebase from JavaScript to TypeScript so that I could generate data.d.ts easily, but because I was not sure if you wanted to do so, I didn't rewrite it this time.