Fix incorrect check which always yields true#22
Open
rexxars wants to merge 1 commit intofreeall:masterfrom
Open
Fix incorrect check which always yields true#22rexxars wants to merge 1 commit intofreeall:masterfrom
rexxars wants to merge 1 commit intofreeall:masterfrom
Conversation
Author
|
Hate to "bump", but any thoughts on this? |
|
Don't mean to rush you but any chance of getting this addressed soon? ;) For those of you looking for a workaround, you can initialize the progress-stream instance with the option |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I might be overlooking something trivial here, but I can't see any way where
lengthis not a number?It's initialized as 0, so when you pipe an HTTP stream to it, it'll still be 0, and it'll just fall back and not try to read the length from the headers. Surely this isn't how it was supposed to be? :-)