Skip to content
This repository was archived by the owner on Feb 4, 2020. It is now read-only.

Conversation

@hubx
Copy link
Contributor

@hubx hubx commented Aug 11, 2016

At the moment clcache will fail when parsing a non-existing header to generate includesContentHash for ManifestRepository.getIncludesContentHashForFiles(listOfIncludes) with a non-existing include in listOfincludes

     Traceback (most recent call last):
       File "clcache.py", line 1518, in <module>
       File "clcache.py", line 1409, in main
       File "clcache.py", line 1439, in processCompileRequest
       File "clcache.py", line 1476, in processDirect
       File "clcache.py", line 188, in getIncludesContentHashForFiles
       File "clcache.py", line 188, in <listcomp>
       File "clcache.py", line 688, in getFileHash
     FileNotFoundError: [Errno 2] No such file or directory: 'missing.h'

The proposed is not a elegant solution. I don't see a clever way to raise a ForceCacheMissException which could be handled. Please feel free adapt as you wish.

@webmaster128
Copy link
Contributor

See also #179

The problem is: a missing include does mean that it is a miss. It can also be a header change and the include might be obsolete.

Hubert Hesse added 2 commits August 11, 2016 15:04
If clcache is called with a non existing include, force a cache miss, to
see the compiler error
@webmaster128
Copy link
Contributor

webmaster128 commented Aug 12, 2016

Could you please check, if #179 does the job?

I think I fixed it there.

@hubx
Copy link
Contributor Author

hubx commented Aug 12, 2016

@webmaster128 Technically #179 sounds much more profound what I did here. I saw that you are still committing to that PR just now. Ready to test it when you are. :)

@webmaster128
Copy link
Contributor

I saw that you are still committing to that PR just now. Ready to test it when you are. :)

I am happy with the current state in terms of correctness, thus I pinged you here. Please ignore the coverage fails in #179. Those happen because integrationtests are not counted properly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants