This repository was archived by the owner on Feb 4, 2020. It is now read-only.
Friendlier error messages in case of cache access timeouts #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frerich
force-pushed
the
friendly_timeout_errors
branch
from
b9afef2 to
69c8a57
Compare
In case accessing the object cache times out, don't spew an ugly message like main.CacheLockException: Error! WaitForSingleObject returns 258, last error 183 instead, mention that it's a time out error and that there's an environment variable which can be set to avoid this issue.
Current coverage is 78.96% (diff: 25.00%)@@ master #218 diff @@
==========================================
Files 1 1
Lines 962 965 +3
Methods 0 0
Messages 0 0
Branches 159 160 +1
==========================================
+ Hits 761 762 +1
- Misses 163 165 +2
Partials 38 38
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case accessing the object cache times out, don't spew an ugly message
like
main.CacheLockException: Error! WaitForSingleObject returns 258, last error 183
instead, mention that it's a time out error and that there's an
environment variable which can be set to avoid this issue.
This issue was noticed while discussing #217 .