Feature/add source dir #309
Conversation
frerich
left a comment
frerich
left a comment
There was a problem hiding this comment.
The Git commit log doesn't follow the standard format, and it's not terribly informative. Please see https://github.com/frerich/clcache/wiki/Contributing#commit-logs for how to write commit logs - in particular, it would be great if you could explain the scenario in which this patch helps, how the behaviour is without the patch and how the behaviour is with the patch.
| printTraceStatement("Hashing commandLine: {}".format(commandLine)) | ||
| additionalData = "{}|{}|{}".format( | ||
| compilerHash, commandLine, ManifestRepository.MANIFEST_FILE_FORMAT_VERSION) | ||
| printTraceStatement("Hashing additionalData: {}".format(additionalData)) |
There was a problem hiding this comment.
These two printTraceStatement statements seem unrelated to the commit - can you move them into a separate commit?
| if path.startswith(sourceDir): | ||
| return path.replace(sourceDir, SOURCEDIR_REPLACEMENT, 1) | ||
| return path | ||
| return path |
There was a problem hiding this comment.
The code uses an indentation of four spaces per level. Let's stick to that format (if you like, you can merge this commit into the previous commit while you're at it).
|
I'm not totally sure I understand the feature yet - can you please add some tests (e.g. to |
|
what's the difference between CLCACHE_BASEDIR and CLCACHE_SOURCEDIR? |
2 participants
This modification adds a new base directory for source code that can be used to achieve path independence if your build and source are under different roots.