Rename MySQL namespace to Mysql#188
Merged
WyriHaximus merged 1 commit intofriends-of-reactphp:0.7.xfrom Nov 29, 2023
Merged
Conversation
clue
approved these changes
Nov 28, 2023
Contributor
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for looking into this!
I agree typing the FQCN …\MySQL\Mysql… is somewhat awkward and using the name MySQLClient in #186/#147 didn't really feel like an option either, so it probably makes sense to consistently go with the Mysql casing also for the classname 👍
WyriHaximus
approved these changes
Nov 29, 2023
Member
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
I'm interested in your thoughts on this 👍
Meh but consistency is more important IMHO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the
React\MySQLnamespace toReact\Mysqlwithout any additional code adjustments.Both options are valid when it comes to PSR-4. The specification describes the use of alphabetic characters like this:
Changing the namespace to
React\Mysqlaligns with recent changes made in #186 and #187, where we added aMysqlprefix to name theMysqlClientandMysqlResult. This means my suggested PR improves the consistency when it comes to naming our namespace, classes, and variables.Considering that
v0.7.xalready includes BC-Breaks from #186 and #187, it could be a perfect time to introduce this additional BC-Break as well.I'm interested in your thoughts on this 👍