Skip to content

Fix/json header update activities #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roboli merged 2 commits into from
Jan 16, 2026
Merged

Fix/json header update activities #69

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60ad23c
Include application/json header when PATCHing activity
roboli Jan 15, 2026
35c10f7
Remove never read variables
roboli Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/v1-ready/pipedrive/src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,14 +192,14 @@ export class Api extends OAuth2Requester {
const options: RequestOptions = {
url: this.baseUrl + this.URLs.activityById(activityId),
body: task,
headers: {
"Content-Type": "application/json",
},
};
return this._patch(options);
}

async createActivity(params: ActivityParams): Promise<PipedriveResponse> {
const dealId = get(params, "dealId", null);
const subject = get(params, "subject");
const type = get(params, "type");
Copy link
Author

@roboli roboli Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed new push to PR for canary release, so I removed dead code

const options: RequestOptions = {
url: this.baseUrl + this.URLs.activities,
body: { ...params },
Expand Down
Loading