fix: pass existing config to integration constructor in UpdateIntegration #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Fixes #514 - UpdateIntegration was passing the new config instead of the existing database config to the integration constructor. This broke partial update semantics where onUpdate methods expect to merge changes with the current state via patterns like this._deepMerge(this.config, params.config). Changes: - Pass integrationRecord.config (existing) instead of config (new) to constructor - Add TDD tests verifying partial config update preserves unspecified fields - Update DummyIntegration test double to implement proper onUpdate merge behavior - Add ConfigCapturingIntegration test double for verifying config state
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 22520632 | Triggered | Generic High Entropy Secret | 29da1f3 | packages/core/credential/repositories/tests/credential-repository-documentdb-encryption.test.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
seanspeaks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #514 -
UpdateIntegrationwas passing the new config instead of the existing database config to the integration constructor, breaking partial update semantics.integrationRecord.config(existing) instead ofconfig(new) to constructoronUpdatehandler now correctly receives existing config inthis.configand new config inparams.configTest plan
this.configcontains existing database values whenonUpdateis called