Review for Fritz #17
Open
Review for Fritz #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puddle-editor/source/lib/menu.js
Outdated
Owner
Author
There was a problem hiding this comment.
There is a lot of duplicated code copied from var build = funciont () {...}. Refactor?
Contributor
There was a problem hiding this comment.
Sure, I was half way into factoring it out as a separate module.
Owner
Author
|
@yangit I have left a few comment on this pull request. |
Menu API simplified Renamed navigator => menuRenderer Menu does not know about menuRenderer
* old puddle-syntax removed * view and menu code refactored * keycode replaced with keypressJS lib
Editor.js is now split among cursor.js, menu-builder.js, forest.js Event listener is used across libraries to notify each other of events. See reference.md for better description.
Contributor
|
Please review. |
Owner
Author
There was a problem hiding this comment.
Agreed, syntax.compiler.dumpLine should be compatible with analyst.
Owner
Author
|
+1 |
Contributor
|
Travis is not passing until puddle-syntax version in NPM is bumped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.