fix(!windows): prevents mypy from complaining about findpython.pep514tools #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
approved these changes
Aug 7, 2023
Author
|
https://github.com/frostming/findpython/actions/runs/5577259406/job/15673230632?pr=23#step:5:136 I have already seen this error but I cannot remember how to fix it. |
frostming
force-pushed
the
main
branch
2 times, most recently
from
3d813d0 to
7cc1e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On non-windows platform, using
mypy src/orpre-commit run -ayields error on findpython.pep514tools because of the missing librarieswinreg(or_winregfor python 2.7).This PR fixes this parsing errors by checking
sys.platformandsys.version_infoinfindpython.pep514toolseither to import the right module or defines placeholders. mypy detects these tests and acts accordingly, cf. https://mypy.readthedocs.io/en/stable/common_issues.html#python-version-and-system-platform-checks.