-
Notifications
You must be signed in to change notification settings - Fork 18
chore: upgrade deps, improve type hints and add make file for development #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b833caa
chore: upgrade deps, improve type hints and check style in ci
waketzheng 3c25986
chore: improve type hints
waketzheng fdf0337
chore: remove mypy from dev deps
waketzheng b6927db
ci: remove style check
waketzheng b21aa88
Merge branch 'main' of github.com:frostming/findpython
waketzheng 97e57a8
chore: only imports sys when type checking
waketzheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
| *.py[cod] | ||
| __pycache__/ | ||
| venv/ | ||
| .venv/ | ||
| .tox/ | ||
| .vscode/ | ||
| /build/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| checkfiles = src/ tests/ | ||
|
|
||
| help: | ||
| @echo "FindPython development makefile" | ||
| @echo | ||
| @echo "Usage: make <target>" | ||
| @echo "Targets:" | ||
| @echo " up Updates dev/test dependencies" | ||
| @echo " deps Ensure dev/test dependencies are installed" | ||
| @echo " check Checks that build is sane" | ||
| @echo " test Runs all tests" | ||
| @echo " style Auto-formats the code" | ||
| @echo " lint Auto-formats the code and check type hints" | ||
|
|
||
| up: | ||
| pdm update --verbose | ||
|
|
||
| deps: | ||
| ifeq ($(wildcard .venv),) | ||
| pdm install --verbose | ||
| else | ||
| pdm install | ||
| endif | ||
|
|
||
| _check: | ||
| pdm run ruff format --check $(checkfiles) | ||
| pdm run ruff check $(checkfiles) | ||
| pdm run mypy $(checkfiles) | ||
| check: deps _build _check | ||
|
|
||
| _style: | ||
| pdm run ruff format $(checkfiles) | ||
| pdm run ruff check --fix $(checkfiles) | ||
| style: deps _style | ||
|
|
||
| _lint: | ||
| pdm run ruff format $(checkfiles) | ||
| pdm run ruff check --fix $(checkfiles) | ||
| pdm run mypy $(checkfiles) | ||
| lint: deps _build _lint | ||
|
|
||
| _test: | ||
| pdm run pytest -s tests | ||
| test: deps _test | ||
|
|
||
| _build: | ||
| rm -fR dist/ | ||
| pdm build | ||
| build: deps _build | ||
|
|
||
| # Usage:: | ||
| # make venv version=3.12 | ||
| venv: | ||
| pdm venv create $(version) | ||
| pdm run pip install --upgrade pip |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.