Skip to content

Conversation

@keisau
Copy link
Contributor

@keisau keisau commented Feb 3, 2026

Notable changes

  1. UnitIsPlayer and other similar functions wrapped with issecretvalue and pcall.

Other changes

  1. From Midnight pre-patch, Addons' file modes are converted to 0777 by the game. This will taint the whole repository. To ignore file mode changes, run git config core.fileMode false.
  2. Trailing spaces and missing newline in last line in all files are quite a headache. All staged files no longer contain trailing spaces and now has a newline at the end of the file.
  3. Added .gitignore.

@keisau keisau force-pushed the main branch 6 times, most recently from 58ba840 to f807c46 Compare February 4, 2026 02:12
@frozn frozn added 1_bug Something isn't working 2_to develop Development can begin labels Feb 4, 2026
@frozn
Copy link
Owner

frozn commented Feb 4, 2026

Thanks for the PR! 👍

About the removed trailing spaces:

  1. Unfortunately it's hard to see the "real" fixes in the diff.
  2. To be honest, I'd like to keep them.

@frozn frozn marked this pull request as draft February 4, 2026 23:18
@keisau
Copy link
Contributor Author

keisau commented Feb 5, 2026

Thanks for the PR! 👍

About the removed trailing spaces:

  1. Unfortunately it's hard to see the "real" fixes in the diff.
  2. To be honest, I'd like to keep them.

Modern text editors tend to remove trailing spaces. If this is preferred, please attach a working config like .vscode as a reference. The default config of VSCode, Zed, etc, truncates trailing spaces.

# Conflicts:
#	TipTac/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua
#	TipTac/modules/ttBars.lua
#	TipTacItemRef/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua
#	TipTacOptions/Libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua
#	TipTacTalents/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua

# Conflicts:
#	TipTac/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua
#	TipTacItemRef/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua
#	TipTacOptions/Libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua
#	TipTacTalents/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua

# Conflicts:
#	TipTac/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua
#	TipTac/modules/ttStyle.lua
#	TipTac/ttCore.lua
#	TipTacItemRef/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua
#	TipTacOptions/Libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua
#	TipTacTalents/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1_bug Something isn't working 2_to develop Development can begin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants