Open
Conversation
Introduces snapshot testing using the insta crate to verify formatter output consistency. This provides visual regression testing for the Emitter's Ruby code formatting capabilities. Test cases cover: - Basic class/module formatting - Method definitions (with and without parameters) - Conditional statements (if) - Case/when expressions - While loops The snapshot tests use JSON AST input and source code to validate the formatter output, enabling easy detection of formatting regressions. Closes #63 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Cases
以下のRuby構文のフォーマット結果をsnapshotとして記録:
How to Run
How to Add New Tests
ext/rfmt/src/emitter/mod.rsのsnapshot_testsモジュールにテストを追加cargo testを実行（新しい.snap.newファイルが生成される）cargo insta reviewで内容を確認・承認Closes #63