Skip to content

Fix duplicate comment output when method chain has block #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fs0414 merged 1 commit into from
Feb 1, 2026
+37 −0
Merged

Fix duplicate comment output when method chain has block #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ext/rfmt/src/emitter/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,6 +1196,16 @@ impl Emitter {
if let Some(text) = self.source.get(start..end) {
// Trim trailing whitespace but preserve the content
write!(self.buffer, "{}", text.trim_end())?;

// Mark comments within the extracted range as emitted
for (idx, comment) in self.all_comments.iter().enumerate() {
if !self.emitted_comment_indices.contains(&idx)
&& comment.location.start_offset >= start
&& comment.location.end_offset <= end
{
self.emitted_comment_indices.insert(idx);
}
}
}
}

Expand Down
27 changes: 27 additions & 0 deletions spec/rfmt_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,33 @@ def bar = 42
source = "[1, 2].map { |x| x * 2 } # double\n"
expect(Rfmt.format(source)).to eq("[1, 2].map { |x| x * 2 } # double\n")
end

it 'does not duplicate inline comments on method chain with block' do
source = <<~RUBY
some_method # comment
.method_with_block { do_something }
RUBY

result = Rfmt.format(source)

# The comment should appear exactly once, not be duplicated
expect(result.scan('# comment').count).to eq(1)
expect(result).to eq(source)
end

it 'does not duplicate inline comments on method chain with do-end block' do
source = <<~RUBY
some_method # comment
.method_with_block do
do_something
end
RUBY

result = Rfmt.format(source)

# The comment should appear exactly once
expect(result.scan('# comment').count).to eq(1)
end
end
end

Expand Down
Loading