Fix duplicate comment output when method chain has block#89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Fixes a bug where inline comments were duplicated in the output when formatting code with chained method calls that include blocks.
Before (bug):
After (fixed):
🔧 Changes
Core Fix
emit_call_without_block(): Added logic to mark comments within the extracted source range as emitted, preventing duplicate output in subsequent processingRoot Cause
When
emit_call_without_block()extracts source text fromcall_node.start_offsettoblock_node.start_offset, inline comments are included in the extracted text. However, these comments were not being marked inemitted_comment_indices, causing them to be output again by later comment-handling routines.Test Coverage
{ })🗂️ Changed Files
ext/rfmt/src/emitter/mod.rsspec/rfmt_spec.rb🧪 Testing
Test Execution
bundle exec rspecResults
Verification
rfmt --diff📦 Breaking Changes
None
Related Issue
Closes #85