Avoid assertion failure when using Host Device#32
Avoid assertion failure when using Host Device#32adriansr wants to merge 1 commit intofsnotify:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 71.18% 71.28% +0.09%
==========================================
Files 3 3
Lines 288 289 +1
==========================================
+ Hits 205 206 +1
Misses 61 61
Partials 22 22
Continue to review full report at Codecov.
|
|
@adriansr sorry nobody has looked at this. Can you please rebase on master and see if the tests pass? |
|
This github conflict editor is nonsense. Please rebase this branch to get upgraded travis tests for 1.10. |
|
@drewwells it's rebased now. Thanks for looking at this :) |
|
@adriansr this PR does not fix the assertion message. Applying your patch and changing the test to use dev id 0 results in the same error message: |
|
@patsoffice I clearly have broken something. It seems on May I sent a different fix and for some reason overwrote this branch. Let me see if I can find the original. |
Passing a device ID of zero (Host device) to FSEventsCopyUUIDForDevice causes the following assertion failure error to be printed to the logs: (FSEvents.framework) FSEventsCopyUUIDForDevice(): failed assertion 'dev > 0'
|
@patsoffice now it's ok Have a look at #39 too |
|
Closed in favor of @patsoffice PR #38 which is more complete |
Passing a device ID of zero (Host device) to FSEventsCopyUUIDForDevice
causes the following assertion failure error to be printed to the logs: