Updated supported python versions #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleknap
reviewed
Nov 17, 2025
Collaborator
kyleknap
left a comment
kyleknap
left a comment
There was a problem hiding this comment.
Looks fine. Just had a comment on one of the changes.
Comment on lines
-2193
to
-2194
| # Use memoryview to avoid making copies of the bytes when we splice for partitioned uploads | ||
| data = memoryview(data) |
Collaborator
There was a problem hiding this comment.
Instead shouldn't we be keeping these lines and just remove the conditional? Now that adlfs will only support 3.10+ it will also mean it will only use the SDK on 3.10+ python versions which should always support memory views.
kyleknap
approved these changes
Nov 18, 2025
Collaborator
kyleknap
left a comment
kyleknap
left a comment
There was a problem hiding this comment.
Look good to me! 🚢
@martindurant this should be good for a review on your side and merge if it looks good to you
Collaborator
|
This PR fixes: #520 for reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed support for Python 3.9 and added support for Python 3.14.