Correct find behaviour with different combinations of arguments for ZipFileSystem
#1976
+67
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
martindurant
left a comment
martindurant
left a comment
There was a problem hiding this comment.
Looking good, just a couple of simple questions.
| raise ValueError("maxdepth must be at least 1") | ||
|
|
||
| def to_parts(_path: str): | ||
| return list(filter(None, _path.replace("\\", "/").split("/"))) |
Member
There was a problem hiding this comment.
"\" is a single slash because of escaping - is that the intent?
Contributor
Author
There was a problem hiding this comment.
Yes, '\' needs to be escaped otherwise using r'\' should be equivalent.
fsspec/implementations/zip.py
Outdated
| def _matching_starts(file_path): | ||
| file_parts = filter(lambda s: bool(s), file_path.split("/")) | ||
| return all(a == b for a, b in zip(path_parts, file_parts)) | ||
| path_depth = len(path_parts := to_parts(path)) |
Member
There was a problem hiding this comment.
I find it clearer to write out
Suggested change
| path_depth = len(path_parts := to_parts(path)) | |
| path_parts = to_parts(path) | |
| path_depth = len(path_parts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1974 #1975