upgrade jquery version due to vulnerability #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taofeeqib
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
The jQuery has been updated to the latest version (3.6.0) https://jquery.com/download/
Taofeeqib
approved these changes
Apr 20, 2022
Taofeeqib
left a comment
Taofeeqib
left a comment
There was a problem hiding this comment.
jQuery has been updated to the latest version (3.6.0) https://jquery.com/download/
adolsalamanca
approved these changes
Apr 22, 2022
dragonsinth
reviewed
Jun 2, 2022
| "grpc-logo.png": {grpcLogoPng, map[string]*bintree{}}, | ||
| "index-template.html": {indexTemplateHtml, map[string]*bintree{}}, | ||
| "jquery-3.4.1.min.js": {jquery341MinJs, map[string]*bintree{}}, | ||
| "jquery-3.6.0.min.js": {jquery341MinJs, map[string]*bintree{}}, |
Member
There was a problem hiding this comment.
unfamiliar with this code, but: this line still says jquery341MinJs?
Member
|
Hmm... looking at this more, I think you're not supposed to just patch bindata.go directly. I think you're supposed to update the resources in go-bindata-all.sh? |
spatecon
approved these changes
Dec 21, 2022
spatecon
left a comment
spatecon
left a comment
There was a problem hiding this comment.
But maybe bindata should be regenerated before merge by maintainer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two vulnerabilities with jquery versions older than 3.5:
https://nvd.nist.gov/vuln/detail/CVE-2020-11022
https://nvd.nist.gov/vuln/detail/CVE-2020-11023