fuxt - useEventListener #147
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a few places in UCLA that they forgot to remove event listener when component unmounts, which can lead to memory leaks etc.
I added a simple composable that automatically adds/removes event listener using onMount/onBeforeUnmount which can be useful for us as well.
Since we are using Vite with our Nuxt3 apps, Vite will perform tree shaking when building a project and get rid of unused code (including custom composables as well) and will not include them in the final bundle