Add the ability to override the dialect to be used for generating the CSV

[schraal]

I've added the ability to override the dialect to be used for generating the CSV. See the documentation.

[rockymeza]

Hi @schraal!

This is great! I always knew we needed to add this behavior, but I just never got around to it.

The only thing that this PR needs is some tests and then I think it will be ready to go live. If you need help adding the tests, I could help.

Thanks!

[rockymeza]

default,

[schraal]

Hi Rocky,

How do you run the unit tests? Tried a bit, but I keep getting errors:

Error
Traceback (most recent call last):
File
"/Users/schraal/projects/django-separated/django-separated/separated/tests.py",
line 171, in test_unicode_filename
response = self.client.get(reverse('unicode_filename'))
File
"/Users/schraal/projects/django-separated/VENV/lib/python2.7/site-packages/django/test/client.py",
line 500, in get
**extra)
File
"/Users/schraal/projects/django-separated/VENV/lib/python2.7/site-packages/django/test/client.py",
line 303, in get
return self.generic('GET', path, secure=secure, **r)
File
"/Users/schraal/projects/django-separated/VENV/lib/python2.7/site-packages/django/test/client.py",
line 379, in generic
return self.request(**r)
File
"/Users/schraal/projects/django-separated/VENV/lib/python2.7/site-packages/django/test/client.py",
line 466, in request
six.reraise(_exc_info)
File
"/Users/schraal/projects/django-separated/VENV/lib/python2.7/site-packages/django/core/handlers/base.py",
line 132, in get_response
response = wrapped_callback(request, *callback_args, *_callback_kwargs)
File
"/Users/schraal/projects/django-separated/VENV/lib/python2.7/site-packages/django/views/generic/base.py",
line 71, in view
return self.dispatch(request, _args, *_kwargs)
File
"/Users/schraal/projects/django-separated/VENV/lib/python2.7/site-packages/django/views/generic/base.py",
line 89, in dispatch
return handler(request, _args, *_kwargs)
File
"/Users/schraal/projects/django-separated/VENV/lib/python2.7/site-packages/django/views/generic/list.py",
line 175, in get
return self.render_to_response(context)
File
"/Users/schraal/projects/django-separated/django-separated/separated/views.py",
line 56, in render_to_response
writer.writerow(self.get_row(obj))
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-3:
ordinal not in range(128)

2015-10-27 3:05 GMT+01:00 Rocky Meza notifications@github.com:

Hi @schraal https://github.com/schraal!

This is great! I always knew we needed to add this behavior, but I just
never got around to it.

The only thing that this PR needs is some tests and then I think it will
be ready to go live. If you need help adding the tests, I could help.

Thanks!

—
Reply to this email directly or view it on GitHub
#4 (comment)
.

Hilbert Schraal, Hippe IT
Web-, mobiele apps

Canadalaan 31, 9728 EA Groningen
085-8778899 | 06-53814582 | www.hippe.it | kvk: 02099377

[rockymeza]

Hi,

It's been a long time since I've run the tests! I just pushed a commit that updates the tests to support Django 1.8.

You can run the tests by running:

$ python setup.py test