Enable the usage of Roles rather then AWS Access Key and Secret Key#1
Open
jarnohenneman wants to merge 6 commits intofuturevision:masterfrom
jarnohenneman:master
Open
Enable the usage of Roles rather then AWS Access Key and Secret Key#1jarnohenneman wants to merge 6 commits intofuturevision:masterfrom jarnohenneman:master
jarnohenneman wants to merge 6 commits intofuturevision:masterfrom
jarnohenneman:master
Conversation
Collaborator
|
I'm so sorry I didn't see this PR, thanks for your work! I am wondering about the hardcoded reference to "dev-efs-8xabdop9fqb1" though, could you explain me why we need this? |
Author
|
No worries; the reference to the bucket (dev-efs-8xabdop9fqb1) is just for documentation. You can change it to <bucket_name> or something similar if you want :-) |
Collaborator
|
If you can update the PR and change the bucket name into something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the usage of Container role rather then AWS Access Key and Secret Key