Skip to content

Comments

update offers a dark mode compatible collection of Gdk background overrides#185

Open
csylvain wants to merge 1 commit intog0orx:masterfrom
csylvain:darkmode
Open

update offers a dark mode compatible collection of Gdk background overrides#185
csylvain wants to merge 1 commit intog0orx:masterfrom
csylvain:darkmode

Conversation

@csylvain
Copy link

built pihpsdr and found all the menus were white text on white background.
created a Makefile option to use new file bkgnd.h which contains a background color definition which is not 'white'.
changed all the menu code to use the new option when enabled.
note: the discovery menu is unique in that it is similar but not exactly the same override variable as all the others.
also see #28

@petrus-lt
Copy link

I didn't tried this change but @markusgrosser one from #28, which works fine if you adapt it to current code (see my non-white-menu branch).
Two things I see with your diff:

  • you also hardcode background colors, so now we have two options instead of one. Can't this be handled by the WM instead, like in @markusgrosser PR?
  • you added main.c with your custom resolution (1366x768) in the diff, this should be removed.

But without a change like this, pihpsdr is pretty unusable for me, so I'd welcome such a change.

@dl1ycf
Copy link
Contributor

dl1ycf commented Sep 14, 2023

The dl1ycf version is now fully compatible with both white and dark mode, and does minimal fiddling around
and leaves nearly everything to GTK.

@petrus-lt
Copy link

@dl1ycf Thanks, indeed. I found your fork afterwards. I'm using it now.

@csylvain
Copy link
Author

csylvain commented Sep 16, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants