update offers a dark mode compatible collection of Gdk background overrides#185
Open
csylvain wants to merge 1 commit intog0orx:masterfrom
Open
update offers a dark mode compatible collection of Gdk background overrides#185csylvain wants to merge 1 commit intog0orx:masterfrom
csylvain wants to merge 1 commit intog0orx:masterfrom
Conversation
|
I didn't tried this change but @markusgrosser one from #28, which works fine if you adapt it to current code (see my non-white-menu branch).
But without a change like this, pihpsdr is pretty unusable for me, so I'd welcome such a change. |
Contributor
|
The dl1ycf version is now fully compatible with both white and dark mode, and does minimal fiddling around |
|
@dl1ycf Thanks, indeed. I found your fork afterwards. I'm using it now. |
Author
|
i meant to mention the DL1YCF fork cured all the various hard-coded GTK
stuff making PiHPSDR fully usable without regard to a user's theme choice.
glad to see you found your way to it, despite my inattention to this issue!
…On Fri, Sep 15, 2023 at 4:58 AM petrus-lt ***@***.***> wrote:
@dl1ycf <https://github.com/dl1ycf> Thanks, indeed. I found your fork
afterwards. I'm using it now.
—
Reply to this email directly, view it on GitHub
<#185 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRUYNM5MXV43F66O5PF3TTX2QKEDANCNFSM6AAAAAAYAYX3JM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
built pihpsdr and found all the menus were white text on white background.
created a Makefile option to use new file bkgnd.h which contains a background color definition which is not 'white'.
changed all the menu code to use the new option when enabled.
note: the discovery menu is unique in that it is similar but not exactly the same override variable as all the others.
also see #28