Stable v3 & React 16 compat

[gregberge]

This PR is a first step to be compatible with React 16, some tests are not passing. I tried to investigate but I need help.

[gregberge]

I thought it was related to enzyme and update issue but I tried with pure ReactDom.render and I have the same issues. Looks like react-deep-force-update or react-proxy is not compatible with React 16. @gaearon do you have an idea?

[gaearon]

Is it certainly using the very latest version of react-deep-force-update?

[gregberge]

@gaearon yes 😕

[gregberge]

@gaearon I dove into react-deep-force-update and it looks like stateNode is not updated.

https://github.com/gaearon/react-deep-force-update/blob/89506f42004843bd7297d44fdbd535fa2c9735cc/src/index.js#L83-L86

I think node of type "HostComponent" are not updated. How to force an update of these nodes?

[gregberge]

@gaearon problem occurs only with stateless functional components, they are not updated and the function is not called. If I switch it by a class based component, it works.

[gregberge]

@gaearon also I used the react-deep-force-update proposed in gaearon/react-deep-force-update#9. I updated code, if you want to investigate, just switch to my PR and run jest --watch test/HotContainer.dev.test.js. If we make this test pass, it is good.

[gregberge]

@gaearon I finally found the problem, in the following case, App will not be reloaded because element instance is not recreated. It was the case in React 15. I think it is a minor regression but it has to be noticed.

const App = () => <div />
const element = <App />
ReactDOM.render(<HotContainer>{element}</HotContainer>, main)

[ntucker]

Thanks for working vigilantly on React 16 compatibility @neoziro ! :)

[gregberge]

@ntucker I try 🙂