fix target crash issue caused by movaps alignment requirement#17
Open
CubicStone31 wants to merge 1 commit intogaffe23:masterfrom
Open
fix target crash issue caused by movaps alignment requirement#17CubicStone31 wants to merge 1 commit intogaffe23:masterfrom
CubicStone31 wants to merge 1 commit intogaffe23:masterfrom
Conversation
justanothermatt
approved these changes
Mar 23, 2022
justanothermatt
left a comment
There was a problem hiding this comment.
This solved my segfault problem as well and would explain multiple issues on the issue board. This should be pulled asap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some machines of linux x86_64, dlopen() may use movaps instruction, and this requires the target memory (often the stack) to be properly aligned. If not, it will crash the program.
For example, on my machine, the injection failed with this error:
Then after I attached gdb to the injected process. I found it stopped at movaps instruction
and current RSP is 0x7ffe3049fb78. It is not aligned as required.
You can find movaps's alignment issue in detail here: https://www.felixcloutier.com/x86/movaps
Adding a
and $0xfffffffffffff000, %rsp \nto the beginning of the shellcode should fix this.