James C fix height of saved queries #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
…+ comment changes Signed-off-by: James Cocker <james.s.earth@gmail.com>
…ing effect Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
eamansour
approved these changes
Dec 11, 2025
Member
eamansour
left a comment
eamansour
left a comment
There was a problem hiding this comment.
Looks good! Just a few minor comments but happy to approve :)
galasa-ui/src/components/test-runs/saved-queries/CollapsibleSideBar.tsx
Outdated
Show resolved
Hide resolved
galasa-ui/src/components/test-runs/saved-queries/CollapsibleSideBar.tsx
Outdated
Show resolved
Hide resolved
galasa-ui/src/components/test-runs/saved-queries/CollapsibleSideBar.tsx
Outdated
Show resolved
Hide resolved
galasa-ui/src/tests/components/test-runs/saved-queries/CollapsibleSideBar.test.tsx
Outdated
Show resolved
Hide resolved
galasa-ui/src/components/test-runs/saved-queries/CollapsibleSideBar.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Fixes #2492
Dynamically sizes the nav bar even though the bar has a scrollable list of items by shrinking it to 700px, taking a snapshot of the height of the main content, and sizes accordingly. Necessary to shrink as the wrapper must be set to a fixed height, like how it was before this PR.