Open
Conversation
Author
|
ping @galen |
|
I'm having the exact same issues, modifying the redirect_uri always gives a "Redirect URI doesn't match original redirect URI" error. I'm having to work around this currently by saving the states in session before redirecting, and them reading them on return. Works, but not the most efficient way. |
Author
|
@GreatPotato yes, that's the same issue I faced, which made me create this pull request. @galen I'm pretty sure many others would have encountered this problem, working around it in their own ways. That's why I think it'll be nice to have this commit merged. Will ease a lot of similar problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While authenticating a user and fetching the access token, the functions currently do not accept parameters that override the initial config. This can be a hassle when you'd want to change the config at runtime.
For example, if the specified redirect_uri in the config is
www.my_redirect.com, I'd want to pass some data to the redirect handler, to allow dynamic behaviour,like so :
www.my_redirect.com?q=runtimeValuewhich would help the redirect handler logic to behave differently.
These commits parameterize the functions to allow this behaviour.