Orientation

[smitpatwa]

Fix for issue #52.

[hvk3]

There seems to be some problem in your implementation, I guess. Try constructing a full binary tree of 7 nodes in vertical orientation, and view that in horizontal orientation.

[stengel]

Hi, this is correct - I do not think horizontal orientation
works at all yet.

Could you please introduce yourself so that your activity is
going in the right direction?

Thanks and regards,
--Bernhard

• hvk3 notifications@github.com [08-03-2016 05:54:05 -0800]:

There seems to be some problem in your implementation, I guess. Try constructing a full binary tree of 7 nodes in vertical orientation, and view that in horizontal orientation.

---

Reply to this email directly or view it on GitHub:
#54 (comment)

Prof Bernhard von Stengel email: stengel@nash.lse.ac.uk
Department of Mathematics http://www.maths.lse.ac.uk/Personal/stengel
London School of Economics phone: +44-20-7955 6438 (office)
Houghton St, Room COL 4.12 +44-20-7226 2325 (home)
London WC2A 2AE, United Kingdom

[smitpatwa]

@hvk3
I have checked many cases for vertical and corresponding horizontal orientation.
I cannot find any error.
Can you please share a screenshot where it is not drawing the tree properly?

[smitpatwa]

This are the screen shot of a tree in horizontal orientation and vertical orientation

[smitpatwa]

@stengel
I am Smit Patwa, pursuing BE(Hons) Computer Science at Birla Institute of Technology and Science, Pilani (BITS Pilani,India).
I am interested in working for this project. I got this project link from the GSOC 2016 website.

[hvk3]

@smitpatwa
I believe I made some error while testing your code. Works fine now. Sorry for the inconvenience.