Skip to content

Conversation

@hkirat
Copy link
Contributor

@hkirat hkirat commented Mar 17, 2016

No description provided.

@hkirat
Copy link
Contributor Author

hkirat commented Mar 18, 2016

The First Commit fixes 64. It is a general method to follow and isn't browser specific.

The commits that follow add functionality to undo a previously made move.
It works as follows :
A global GTE.TREE.CHANGES array stores the nodes that are changed in a particular move.
I've introduced a "Changes" class to keep track of a particular change.
Whenever the user calls undo, the Changes array is popped and the previous state is restored.
The method followed is different from the ones suggested in #53, though it is partly based on the second suggestion. Rather than the complete state I'm just storing the changes after each move.
Hope it makes sense.

@kagolaub
Copy link

I very much like this implementation; it was very similar to my own. Good work hkirat!

@stengel
Copy link
Member

stengel commented Mar 18, 2016

Dear Harkirat,

I am one of the GSoC organizers and saw your impressive
quick solution of UNDO and other things (there will be more
details needed but it is a good start). Can you email me
directly to talk about your possible involvement with
Gambit/GTE as a GSoC student if you are interested?

Best regards,
--Bernhard

The First Commit fixes 64. It is a general method to follow and isn't browser specific.

The commits that follow add functionality to undo a previously made move.
It works as follows :
A global GTE.TREE.CHANGES array stores the nodes that are changed in a particular move.
I've introduced a "Changes" class to keep track of a particular change.
Whenever the user calls undo, the Changes array is popped and the previous state is restored.
The method followed is different from the ones suggested in #53, though it is partly based on the second suggestion. Rather than the complete state I'm just storing the changes after each move.
Hope it makes sense.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#66 (comment)

Prof Bernhard von Stengel email: stengel@nash.lse.ac.uk
Department of Mathematics http://www.maths.lse.ac.uk/Personal/stengel
London School of Economics phone: +44-20-7955 6438 (office)
Houghton St, Room COL 4.12 +44-20-7226 2325 (home)
London WC2A 2AE, United Kingdom

@hkirat
Copy link
Contributor Author

hkirat commented Mar 19, 2016

Thanks guys!
@stengel Mailed to stengel@nash.lse.ac.uk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants