Add constructive recognition for SL_n #330

danielrademacher · 2024-06-19T12:22:59Z

No description provided.

Make sure that the correct path of `regen_doc.g` is used when PackageManager builds the documentation.

preliminary fix in `makedoc.g`

fingolfin · 2024-06-19T12:39:37Z

PackageInfo.g

  GAP := ">=4.11",
  NeededOtherPackages := [
    ["AtlasRep", ">= 1.4.0"],
+    ["Alnuth", ">= 3.2.1"],


PackageInfo.g

gap/projective/constructive_recognition/utils/achieve.gi

fingolfin · 2024-06-19T12:41:05Z

gap/projective/constructive_recognition/utils/achieve.gi

      if IsEvenInt(q) then
          std := RECOG.RecogniseSL2NaturalEvenChar(gm,f,false);
-          ri!.comment := "PSL2Even";
+          ri!.comment := "_PSL2Even";


Any reason this was changed? It causes CI tests to fail

Suggested change

ri!.comment := "_PSL2Even";

ri!.comment := "PSL2Even";

gap/projective/constructive_recognition/utils/achieve.gi

fingolfin · 2024-06-20T10:06:43Z

Sometimes this still runs into an error:

gap> res:=RECOG.FindStdGensSmallerMatrices_SL(SL(50,5)); time;
Error, List Element: <list>[2] must have an assigned value in
  for ele in eigenspaceGenerators[2] do
    vec := zerovec;
    for j in [ 1 .. Size( ele ) ] do
        vec := vec + ele[j] * result[j];
    od;
    Add( sl2eigenspacebase, vec );
od; at GAPROOT/pkg/recog/gap/projective/constructive_recognition/SL/GoingDown.gi:605 called from
RECOG.Computesl2Subspace( baselist, eigenspacelist
 ) at GAPROOT/pkg/recog/gap/projective/constructive_recognition/SL/GoingDown.gi:545 called from
RECOG.SLn_constructsl2WithSmallerMatrices( sld, d, q
 ) at GAPROOT/pkg/recog/gap/projective/constructive_recognition/SL/main.gi:162 called from
<function "unknown">( <arguments> )
 called from read-eval loop at *stdin*:2
type 'quit;' to quit to outer loop

If one wants to build the documentation with version 1.4.3 of PackageManager then also the calls of `OutputTextFile` require paths relative to `DirectoryCurrent()`.

fingolfin · 2024-06-20T13:51:45Z

The TestRecogGL tests systematically fail.

... and add some comments (pointing out this needs documentation, and also an obvious bug in the code that would lead to an unexpected error if the code it is in was ever run)

... which made it depend on the characteristic. This corresponds to a change in our manuscript where it turned out we don't need this, and experiments validate this.

The GAP kernel already does that and this is way faster.

Daniel Rademacher and others added 8 commits June 13, 2024 14:59

Include SL Code.

941ccd0

Remove some deleted files from read.g

cf89f14

Add fix for manual crash.

df70f5e

Implement Max remark

7fbadd0

preliminary fix in makedoc.g

e5e2bd7

Make sure that the correct path of `regen_doc.g` is used when PackageManager builds the documentation.

Merge remote-tracking branch 'upstream/master' into merge_master

0ada415

New version and add dependencies

f2b49f5

Merge pull request #1 from ThomasBreuer/TB_install

1aa2941

preliminary fix in `makedoc.g`

fingolfin changed the title ~~Include constructive recognition sl~~ Add constructive recognition for SL_n Jun 19, 2024

fingolfin reviewed Jun 19, 2024

View reviewed changes

fingolfin added 4 commits June 20, 2024 12:02

typo

6502e3b

simplify

9353440

cleanup

bbb4f70

Debug GenerateRandomKernelElementsAndOptionallyVerifyThem

2616344

fingolfin and others added 3 commits June 20, 2024 12:37

Remove some dead (commented out) code

01c2703

Restore some code

3847eb7

fix more places where the current directory is needed

36bbef1

If one wants to build the documentation with version 1.4.3 of PackageManager then also the calls of `OutputTextFile` require paths relative to `DirectoryCurrent()`.

fingolfin added 11 commits March 18, 2025 14:00

merge master

47b7bfc

Remove unused misc/up.gi

ba933a4

Factor out some duplicate code

47e2dd7

Fix error in Computesl2Subspace

5b50878

... and add some comments (pointing out this needs documentation, and also an obvious bug in the code that would lead to an unexpected error if the code it is in was ever run)

Get rid of GoalDim

d6c5130

Fix bug where FewGensAbelian was only used for perm groups

d5dfadd

GoingUp: remove special case for initial stingray

ea7e6a2

... which made it depend on the characteristic. This corresponds to a change in our manuscript where it turned out we don't need this, and experiments validate this.

Pass field not field size to ConvertToMatrixRep

449b989

When compute a^b don't handle b=1 specially

6c99f9b

The GAP kernel already does that and this is way faster.

Merge branch 'master' into Include_ConstructiveRecognition_SL

c4840ee

Some notes from debugging last year

ab0951e

Merge branch 'master' into Include_ConstructiveRecognition_SL

e87c8f3

fingolfin added the recog days 2025 label Dec 8, 2025

This was referenced Dec 8, 2025

Error in SLPforElementFuncsProjective.PSL2 #317

Open

Reduce number of arguments of recognition methods #355

Draft

Create a "roadmap" that gives a structured overview of what is there, what is missing, in which order things could be done #358

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add constructive recognition for SL_n #330

Add constructive recognition for SL_n #330

Uh oh!

danielrademacher commented Jun 19, 2024

Uh oh!

fingolfin Jun 19, 2024

Uh oh!

Uh oh!

Uh oh!

fingolfin Jun 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fingolfin commented Jun 20, 2024

Uh oh!

fingolfin commented Jun 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add constructive recognition for SL_n #330

Are you sure you want to change the base?

Add constructive recognition for SL_n #330

Uh oh!

Conversation

danielrademacher commented Jun 19, 2024

Uh oh!

fingolfin Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fingolfin Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fingolfin commented Jun 20, 2024

Uh oh!

fingolfin commented Jun 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants