An/classical

[aniemeyer]

Changed test in NonGenericOrthogonalPlus where we checked whether the orbit of the group on a vector has a certain length to a check whether the length divides the orbit. This is necessary, as the conformal group can merge orbits.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.21%. Comparing base (0a37133) to head (bde2cd2).

Files with missing lines	Patch %	Lines
gap/matrix/classical.gi	0.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   69.12%   69.21%   +0.08%     
==========================================
  Files          43       43              
  Lines       18321    18317       -4     
==========================================
+ Hits        12665    12678      +13     
+ Misses       5656     5639      -17     

Files with missing lines	Coverage Δ
gap/matrix/classical.gi	50.60% <0.00%> (+0.38%)	⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fingolfin]

thanks! I resolved a merged conflict (so you should git pull), and left a few comments. But it's looking very good!

[fingolfin]

example test

gap> G:=Group(...);
gap> r:=RecogniseClassical(G);;
gap> r.isOmegaContained;
false
gap> r.dsfdsf;
dsfdsf