-
Notifications
You must be signed in to change notification settings - Fork 19
Implement StdPresentation
#363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
tst/working/quick/presentation.tst
Outdated
| gap> testPres := function(G, small, projective) | ||
| > local ri,iso,pres,F,hom,rel,projG,projString; | ||
| > if projective then ri := RecogniseProjectiveGroup(G);; else ri := RecogniseGroup(G);; fi; | ||
| > if not HasStdPresentation(ri) then CalcStdPresentation(ri)(ri);; fi; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we'd use InstallMethod(StdPresentation, ..., ri -> CalcStdPresentation(ri)(ri)); then the above line would be redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My last commit implements your suggestion and the test succeeds without the redundant line. I am a bit uncertain about some technical details, which we can discuss on Thursday.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #363 +/- ##
==========================================
- Coverage 78.55% 71.55% -7.01%
==========================================
Files 43 43
Lines 18281 18398 +117
==========================================
- Hits 14361 13164 -1197
- Misses 3920 5234 +1314
🚀 New features to boost your workflow:
|
|
Very nice. I am trying to use this to debug issues #343 reported by @ThomasBreuer . Unfortunately it gets stuck in computing a presentation for a lower-triangular matrix group. In this case: |
First draft for #338.
Already done
StdPresentationfor all non-leaf nodes, usingStdPresentationof the leaf nodes.Hacks that should be improved
StdPresentationusingIsomorphismFpGroupByGenerators. The "find homomorphism" methods should installStdPresentationwhen they find a leaf if possible.Yet to do